aherbert commented on PR #54:
URL:
https://github.com/apache/commons-statistics/pull/54#issuecomment-1714059737
I think the changes are fine. The javadoc rendered locally are good.
You could go one step further and replace all `<code>` with `{@code }`
elements. This is the preferred way to include code in the project.
I believe the large number of commits is due to basing this PR off a fork
that is behind master. Ideally you should have a remote configured that follows
the GH master branch. You never use this for commit. You only need to use `git
pull` to receive the latest commit and then fork to create your PR branch.
Something like this should work to allow tracking the ASF GH branch
```
git remote add asf https://github.com/apache/commons-statistics
# Do this to update your remote and create a branch for a PR
git pull asf master
git checkout asf/master
git checkout -b my-feature-branch
# git switch -c my-feature-branch
```
When you push your feature branch you can push it to your GH remote and open
a PR against the ASF master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
