elharo commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1323778849
########## src/main/java/org/apache/commons/text/cases/CamelCase.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * <p> + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: This is tricky. It's been a while since I needed this but I seem to recall that there is a canonical Unicode case mapping in Unicode Data somewhere that would fit here. I wouldn't use a Locale for this, implicitly or explicitly. I think what we need is whether the character has the Lu property, the Lc property, or neither. See https://en.wikipedia.org/wiki/Unicode_character_property Character.isUpperCase and Character.isLowerCase should be essentially this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
