jkbkupczyk commented on PR #168: URL: https://github.com/apache/commons-net/pull/168#issuecomment-1722255070
> -1 as the PR stands today: The PR does not test anything new that isn't already tested. Before and after this PR, the code coverage is the same at: 40% instructions / 31% branches. Run `mvn clean site -Pjacoco` then open `target/site/jacoco/index.html` Or am I missing something? Hi, @garydgregory I ran `mvn clean site -Pjacoco` both on `master` and `mock_tcp_test_server_daytimetcpclient_tests` and these are the results I've got: **master**  **mock_tcp_test_server_daytimetcpclient_tests**  did you check `site/jacoco/org.apache.commons.net.daytime/DaytimeTCPClient.html`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
