garydgregory commented on code in PR #318: URL: https://github.com/apache/commons-imaging/pull/318#discussion_r1341381002
########## src/main/java/org/apache/commons/imaging/formats/tiff/TiffReader.java: ########## @@ -16,27 +16,29 @@ */ package org.apache.commons.imaging.formats.tiff; -import static org.apache.commons.imaging.common.BinaryFunctions.read2Bytes; -import static org.apache.commons.imaging.common.BinaryFunctions.read4Bytes; -import static org.apache.commons.imaging.common.BinaryFunctions.readByte; -import static org.apache.commons.imaging.common.BinaryFunctions.readBytes; -import static org.apache.commons.imaging.common.BinaryFunctions.skipBytes; -import static org.apache.commons.imaging.formats.tiff.constants.TiffConstants.TIFF_ENTRY_MAX_VALUE_LENGTH; - import java.io.IOException; import java.io.InputStream; import java.nio.ByteOrder; import java.util.ArrayList; import java.util.List; - import org.apache.commons.imaging.FormatCompliance; import org.apache.commons.imaging.ImagingException; import org.apache.commons.imaging.bytesource.ByteSource; import org.apache.commons.imaging.common.BinaryFileParser; +import static org.apache.commons.imaging.common.BinaryFunctions.read2Bytes; Review Comment: All statics should be grouped at the top. Not sure if Checkstyle can check for us though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
