aherbert commented on PR #1117: URL: https://github.com/apache/commons-lang/pull/1117#issuecomment-1745211972
This is not fixing any bugs, and introduces behaviour changes. The behavioural change is to throw NPE instead of IAE when an argument to reflect on a `target` using `FieldUtils` has created an error. The methods are only documented to throw an NPE if the `target` is null. All other arguments when used incorrectly are documented to throw a IAE. The current code, although internally appears to be incorrect by using `ValidationsUtils.isTrue(something != null, ...)`, is behaving as documented. If you only read the javadoc, and not the source code, the methods are working as specified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
