[ 
https://issues.apache.org/jira/browse/JEXL-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776928#comment-17776928
 ] 

Sebb commented on JEXL-410:
---------------------------

It's not about convenience, it's about not honouring the Javadoc.

As to breaking scripts:
The LEXICAL flags and CONST_CAPTURE appear to be restrictive flags, so could 
cause failures.

AFAICT REGISTER and  FAT_ARROW are permissive, so surely cannot cause script 
failures if enabled?
Indeed if the related syntax was available before the flags were added, then 
omitting them from the default can cause failures.
It looks like the default flag set was updated in the past when new features 
were added - why was this not done for all new flags?

> JexlFeatures: ctor does not enable all features
> -----------------------------------------------
>
>                 Key: JEXL-410
>                 URL: https://issues.apache.org/jira/browse/JEXL-410
>             Project: Commons JEXL
>          Issue Type: Bug
>    Affects Versions: 3.3
>            Reporter: Sebb
>            Assignee: Henri Biestro
>            Priority: Major
>             Fix For: 3.3.1
>
>
> The ctor Javadoc says it "Creates an all-features-enabled instance."
> However, that is not the case, as several flags are not included:
> REGISTER
> LEXICAL
> LEXICAL_SHADE
> FAT_ARROW
> CONST_CAPTURE
> (RESERVED is also omitted, but it is not a feature flag - it only indicates 
> reservedNames is non-empty)
> If these are intentional omissions, they should be documented as such.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to