[
https://issues.apache.org/jira/browse/LOGGING-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761126#comment-17761126
]
Samael Bate edited comment on LOGGING-185 at 10/19/23 2:31 PM:
---------------------------------------------------------------
[https://github.com/apache/commons-logging/pull/157]
I have also raised the following small PR's which would be worth merging as
well:
-[https://github.com/apache/commons-logging/pull/158]- merged
-[https://github.com/apache/commons-logging/pull/159]- merged
was (Author: singingbush):
[https://github.com/apache/commons-logging/pull/157]
I have also raised the following small PR's which would be worth merging as
well:
[https://github.com/apache/commons-logging/pull/158]
[https://github.com/apache/commons-logging/pull/159]
> mvn verify should also be run as part of the github actions workflow
> --------------------------------------------------------------------
>
> Key: LOGGING-185
> URL: https://issues.apache.org/jira/browse/LOGGING-185
> Project: Commons Logging
> Issue Type: Improvement
> Reporter: Samael Bate
> Priority: Major
>
> mvn verify should be run as part of the build pipeline.
> The integration tests are currently broken and I believe they have been since
> [this PR|https://github.com/apache/commons-logging/pull/84] was merged
> because it introduced static imports to {{org.junit.Assert}} which is not on
> the classpath when running {_}mvn verify{_}.
> There is also some incorrect config in the failsafe plugin.
> By reverting the change to both ParentFirstTestCase.java and
> SecurityForbiddenTestCase.java in that PR and fixing the pom I was able to
> successfully run the tests.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
