sebbASF commented on code in PR #497: URL: https://github.com/apache/commons-io/pull/497#discussion_r1368439414
########## src/main/java/org/apache/commons/io/input/TrailerInputStream.java: ########## @@ -0,0 +1,183 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.io.input; + +import java.io.IOException; +import java.io.InputStream; +import org.apache.commons.io.IOUtils; + +/** + * Reads the underlying input stream while holding back the trailer. + * + * <p> + * "Normal" read calls read the underlying stream except the last few bytes (the trailer). The + * trailer is updated with each read call. The trailer can be gotten by one of the copyTrailer + * overloads. + * </p> + * + * <p> + * It is safe to fetch the trailer at any time but the trailer will change with each read call + * until the underlying stream is EOF. + * </p> + * + * <p> + * Useful, e.g., for handling checksums: payload is followed by a fixed size hash, so while + * streaming the payload the trailer finally contains the expected hash (this example needs + * extra caution to revert actions when the final checksum match fails). + * </p> + * + * <p> + * No mark/reset support. + * </p> + * + * <p> + * Not thread-safe. If accessed by multiple threads concurrently, external synchronization is + * necessary. + * </p> + */ +public final class TrailerInputStream extends InputStream { + + // The current implementation is incompatible with mark/reset as it doesn't track which bytes are + // already read and which ones are new. This tracking would be necessary to not overwrite the + // trailer with earlier bytes in the source stream. Remember that the trailer is not meant to + // contain the last read bytes but the last bytes in the stream (which differs when using reset + // to jump to an earlier position of the source stream). Review Comment: The comment needs to explain the choice of super-class. This was done well in the PR, but this summary is a bit too terse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
