Claudenw commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1373190375
##########
src/test/java/org/apache/commons/collections4/bloomfilter/DefaultBloomFilterTest.java:
##########
@@ -215,9 +215,12 @@ public int cardinality() {
}
}
- static class SparseDefaultBloomFilter extends AbstractDefaultBloomFilter {
+ /**
+ * A default implementation of a Sparse bloom filter.
+ */
+ public static class SparseDefaultBloomFilter extends
AbstractDefaultBloomFilter {
- SparseDefaultBloomFilter(final Shape shape) {
+ public SparseDefaultBloomFilter(final Shape shape) {
Review Comment:
Yes, that is exactly the usage. In testing a new BloomFilter implementation
is is handy to have a clean implementation of a sparse filter as used in the
testing to verify correct functioning of the new Bloom filter.
##########
src/test/java/org/apache/commons/collections4/bloomfilter/DefaultBloomFilterTest.java:
##########
@@ -234,9 +237,12 @@ public AbstractDefaultBloomFilter copy() {
}
}
- static class NonSparseDefaultBloomFilter extends
AbstractDefaultBloomFilter {
+ /**
+ * A default implementation of a non-sparse Bloom filter.
+ */
+ public static class NonSparseDefaultBloomFilter extends
AbstractDefaultBloomFilter {
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
