cpreisler commented on PR #437: URL: https://github.com/apache/commons-compress/pull/437#issuecomment-1806919375
I’m away from my computer right now. Let me look this over and make sure the right code got committed. Something may have gotten messed up when I tried to revert the other change. On Sat, Nov 11, 2023 at 3:06 PM Gary Gregory ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorOutputStreamTest.java > <https://github.com/apache/commons-compress/pull/437#discussion_r1390286209> > : > > > +import java.io.IOException; > +import java.util.Arrays; > +import static org.junit.jupiter.api.Assertions.assertTrue; > +import org.junit.jupiter.api.Test; > + > +/** > + * > + * @author Chad Preisler > + */ > +public class FramedLZ4CompressorOutputStreamTest { > + > + @Test > + public void testWriteByteArrayVsWriteByte() throws IOException { > + ByteArrayOutputStream buffer = new ByteArrayOutputStream(); > + StringBuilder sb = new StringBuilder(); > + for (int i = 0; i < 1; i++) { > > Why do you use a loop when this only done once? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-compress/pull/437#pullrequestreview-1726126433>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADVDHDW2LEYSGUM3DDEMOKTYD7SHHAVCNFSM6AAAAAA7HJLUZWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMRWGEZDMNBTGM> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
