garydgregory commented on PR #222: URL: https://github.com/apache/commons-dbutils/pull/222#issuecomment-1822776365
Hi @sanjanarampurkottur01 Hm, ok, then you should not only address the one file, but all files: ``` [ERROR] src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java:[159,23] (design) VisibilityModifier: Variable 'testField' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java:[172,24] (design) VisibilityModifier: Variable 'testField' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/BaseTestCase.java:[68,25] (design) VisibilityModifier: Variable 'rs' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/BaseTestCase.java:[73,25] (design) VisibilityModifier: Variable 'emptyResultSet' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/OutParameterTest.java:[42,23] (design) VisibilityModifier: Variable 'stmt' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/OutParameterTest.java:[44,26] (design) VisibilityModifier: Variable 'parameter' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java:[50,22] (design) VisibilityModifier: Variable 'runner' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java:[51,18] (design) VisibilityModifier: Variable 'handler' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java:[54,16] (design) VisibilityModifier: Variable 'dataSource' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java:[56,16] (design) VisibilityModifier: Variable 'conn' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java:[58,23] (design) VisibilityModifier: Variable 'prepStmt' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java:[60,15] (design) VisibilityModifier: Variable 'stmt' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java:[62,23] (design) VisibilityModifier: Variable 'meta' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java:[64,15] (design) VisibilityModifier: Variable 'results' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/GenerousBeanProcessorTest.java:[65,27] (design) VisibilityModifier: Variable 'processor' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/GenerousBeanProcessorTest.java:[67,23] (design) VisibilityModifier: Variable 'metaData' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/GenerousBeanProcessorTest.java:[69,26] (design) VisibilityModifier: Variable 'propDescriptors' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java:[90,17] (design) VisibilityModifier: Variable 'runner' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java:[92,18] (design) VisibilityModifier: Variable 'handler' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java:[95,16] (design) VisibilityModifier: Variable 'dataSource' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java:[98,16] (design) VisibilityModifier: Variable 'conn' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java:[101,23] (design) VisibilityModifier: Variable 'prepStmt' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java:[104,15] (design) VisibilityModifier: Variable 'stmt' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java:[107,23] (design) VisibilityModifier: Variable 'call' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java:[110,23] (design) VisibilityModifier: Variable 'meta' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java:[113,15] (design) VisibilityModifier: Variable 'results' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java:[116,23] (design) VisibilityModifier: Variable 'resultsMeta' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/QueryRunnerTest.java:[688,17] (design) VisibilityModifier: Variable 'count' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/MockResultSet.java:[280,74] (blocks) EmptyBlock: Empty if block. [ERROR] src/test/java/org/apache/commons/dbutils/handlers/columns/AbstractTestColumnHandler.java:[31,25] (design) VisibilityModifier: Variable 'rs' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/handlers/columns/AbstractTestColumnHandler.java:[32,38] (design) VisibilityModifier: Variable 'handler' must be private and have accessor methods. [ERROR] src/test/java/org/apache/commons/dbutils/handlers/columns/AbstractTestColumnHandler.java:[33,30] (design) VisibilityModifier: Variable 'matchingType' must be private and have accessor methods. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
