[
https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860623#action_12860623
]
Sebb commented on DAEMON-153:
-----------------------------
Since the script is primarily intended for Tomcat6, maybe it should be named
accordingly?
It seems to me that the environment may have JAVA_HOME (and possibly other)
variables already set up, so maybe these would be better defined as defaults,
e.g.
JAVA_HOME=${JAVA_HOME:-/opt/jre1.6.0_18}
Or the script could probably use setclasspath.sh to set JAVA_HOME.
If references to CATALINA_HOME need to be protected by quotes, then CLASSPATH
probably needs to be protected as well as it depends on CATALINA_HOME.
In the longer term, maybe it would be possible to fold the code into
catalina.sh (though that is quite complicated already).
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to
> $CATALINA_BASE/logs).
> - Added comments to give people a hint that further customization sourced
> from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat
> (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
