yakovsh commented on code in PR #442:
URL: https://github.com/apache/commons-compress/pull/442#discussion_r1406841978
##########
src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveConstants.java:
##########
@@ -26,7 +26,7 @@ public final class DumpArchiveConstants {
* The type of compression.
*/
public enum COMPRESSION_TYPE {
- ZLIB(0), BZLIB(1), LZO(2);
+ UNKNOWN(-1), ZLIB(0), BZLIB(1), LZO(2);
Review Comment:
This prevents the NPE on line 208 of TapeInputStream:
https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java#L208
This is also what the "invalid_compression_type.dump" file is testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]