greatmastermario commented on code in PR #786:
URL: https://github.com/apache/commons-lang/pull/786#discussion_r1408775797


##########
src/test/java/org/apache/commons/lang3/builder/DiffBuilderTest.java:
##########
@@ -495,4 +519,16 @@ public void testTriviallyEqualTestEnabled() {
         assertThat(explicitTestAndEqual.build().getNumberOfDiffs(), 
equalToZero);
     }
 
+    @Test
+    public void testNestedDiffable() {

Review Comment:
   After checking out main/master and copy-pasting the test without the code 
fix, I am getting a compilation error due to the generic types, which is what 
was asked to be fixed in the original issue. The test cannot compile without 
the NestedTypeTestClass, so I am unsure why main would be working. Screenshot 
proof prior to the fix is attached.
   
![DiffBuilderGenericCompileFailure](https://github.com/apache/commons-lang/assets/16594743/db4f4b6b-a05f-4eab-97bd-cb68eb1b68a0)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to