[
https://issues.apache.org/jira/browse/DAEMON-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864777#action_12864777
]
Sebb commented on DAEMON-146:
-----------------------------
The line
int o = 0;
is no longer needed - AFAICT the variable "o" is not used anymore.
However that part of the original patch does not seem to have been applied.
Are you OK with removing the variable, or does it need to remain?
> -Xms and -Xmx are included twice
> ---------------------------------
>
> Key: DAEMON-146
> URL: https://issues.apache.org/jira/browse/DAEMON-146
> Project: Commons Daemon
> Issue Type: Bug
> Components: Procrun
> Reporter: David Newcomb
> Priority: Minor
> Fix For: 1.0.3
>
> Attachments: daemon-146.patch
>
>
> Command line:
> "C:\Data\tomcat\bin\tomcat6.exe" //US//Tomcat ^
> --Description "Apache Tomcat - Company App" ^
> --StartClass org.apache.catalina.startup.Bootstrap ^
> --StopClass org.apache.catalina.startup.Bootstrap ^
> --StartParams start ^
> --StopParams stop ^
> --DependsOn MySQL ^
> --StartMode jvm ^
> --StopMode jvm ^
> --JvmOptions "-Dcatalina.base=C:\Data\tomcat" ^
> --JvmOptions "-Dcatalina.home=C:\Data\tomcat" ^
> --JvmOptions "-Djava.endorsed.dirs=C:\Data\tomcat\endorsed" ^
> --JvmOptions "-Djava.io.tmpdir=C:\Data\tomcat\temp" ^
> --JvmOptions
> "-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager" ^
> --JvmOptions
> "-Djava.util.logging.config.file=C:\Data\tomcat\conf\logging.properties" ^
> --JvmOptions "-Dcom.sun.management.jmxremote" ^
> --JvmOptions "-Dcom.sun.management.jmxremote.port=8181" ^
> --JvmOptions "-Dcom.sun.management.jmxremote.authenticate=false" ^
> --JvmOptions "-Dcom.sun.management.jmxremote.ssl=false" ^
> --JvmOptions "-XX:+HeapDumpOnOutOfMemoryError" ^
> --JvmMs 256 ^
> --JvmMx 512 ^
> --Jvm c:\data\java\bin\server\jvm.dll ^
> --JavaHome c:\data\java ^
> --Startup auto
> Produces debug of:
> [2010-03-18 10:11:15] [debug] ( prunsrv.c:1412) Commons Daemon procrun log
> initialized
> [2010-03-18 10:11:15] [info] Commons Daemon procrun (1.0.3.0) started
> [2010-03-18 10:11:15] [info] Running 'Tomcat' Service...
> [2010-03-18 10:11:15] [debug] ( prunsrv.c:1189) Inside ServiceMain...
> [2010-03-18 10:11:15] [info] Starting service...
> [2010-03-18 10:11:15] [debug] ( javajni.c:441 ) Jvm Option[0] -Xms256m
> [2010-03-18 10:11:15] [debug] ( javajni.c:447 ) Jvm Option[1] -Xmx512m
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[2]
> -Dcatalina.base=C:\Data\tomcat
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[3]
> -Dcatalina.home=C:\Data\tomcat
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[4]
> -Djava.endorsed.dirs=C:\Data\tomcat\endorsed
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[5]
> -Djava.io.tmpdir=C:\Data\tomcat\temp
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[6]
> -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[7]
> -Djava.util.logging.config.file=C:\Data\tomcat\conf\logging.properties
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[8]
> -Dcom.sun.management.jmxremote
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[9]
> -Dcom.sun.management.jmxremote.port=8181
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[10]
> -Dcom.sun.management.jmxremote.authenticate=false
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[11]
> -Dcom.sun.management.jmxremote.ssl=false
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[12]
> -XX:+HeapDumpOnOutOfMemoryError
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[13]
> -Djava.class.path=
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[14] -Xms256m
> [2010-03-18 10:11:15] [debug] ( javajni.c:456 ) Jvm Option[15] -Xmx512m
> [2010-03-18 10:11:16] [error] ( javajni.c:611 ) FindClass
> org/apache/catalina/startup/Bootstrap failed
> [2010-03-18 10:11:16] [error] ( prunsrv.c:999 ) Failed loading main
> org/apache/catalina/startup/Bootstrap class
> [2010-03-18 10:11:16] [error] ( prunsrv.c:1304) ServiceStart returned 3
> [2010-03-18 10:11:16] [info] Run service finished.
> [2010-03-18 10:11:16] [error] ( prunsrv.c:1477) Commons Daemon procrun failed
> with exit value: 4
> Xms and Xmx are specified twice.
> There is also no space between Xms 256m and Xmx 512m.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
