garydgregory commented on code in PR #301:
URL: https://github.com/apache/commons-imaging/pull/301#discussion_r1435633510


##########
src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java:
##########
@@ -407,7 +407,11 @@ public byte[] getIccProfileBytes(final ByteSource 
byteSource, final GifImagingPa
     @Override
     public ImageInfo getImageInfo(final ByteSource byteSource, final 
GifImagingParameters params)
             throws ImagingException, IOException {
-        final GifImageContents blocks = readFile(byteSource, false);
+        boolean stopReadingBeforeImageData = true;

Review Comment:
   You've changed the default behavior here which makes the parameter a forced 
usage, which might be a surprised. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to