agoss94 commented on PR #225: URL: https://github.com/apache/commons-geometry/pull/225#issuecomment-1868505809
Thanks @darkma773r I think I am mostly done with all remarks. There is one other thing we should discuss. The original paper [Quickhull](https://dl.acm.org/doi/pdf/10.1145/235815.235821) and this source here [Implementing Quickhull] (http://media.steampowered.com/apps/valve/2014/DirkGregorius_ImplementingQuickHull.pdf) mention facet merging as an error handling strategy. The qhull documentation has similar strategies [Qhull Imprecision](http://www.qhull.org/html/qh-impre.htm). Currently we joggle the input in some place, but leave all vertices fixed. Also we do not merge any facets as can be seen in the unit cube test. I should at least mention, that most sources assume facet merging to be a superior error handling strategy compared to joggling input. The strategy itself is relatively straight forward to understand although it is not immediately obvious how this would fit into our current implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
