[ 
https://issues.apache.org/jira/browse/IO-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary D. Gregory updated IO-337:
-------------------------------
    Fix Version/s: 3.x

> ByteOrderMark can be refactored as an enum
> ------------------------------------------
>
>                 Key: IO-337
>                 URL: https://issues.apache.org/jira/browse/IO-337
>             Project: Commons IO
>          Issue Type: New Feature
>            Reporter: Yaniv Kunda
>            Priority: Minor
>             Fix For: 3.x
>
>         Attachments: ByteOrderMark-enum.patch
>
>
> ByteOrderMark is used primarily for encapsulating the data regarding to 
> Unicode BOMs. Since those are fixed, it would make sense to make it an enum, 
> instead of a public class.
> I have attached a patch that only covers ByteOrderMark itself, including an 
> additional getCharset() utility method, and toString() simplification.
> This patch does not cover:
> 1) Its incorrect use (per its perceived purpose) in 
> XmlStreamReader.XML_GUESS_BYTES
> 2) The now-unnecessary tests



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to