gtoison commented on code in PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#discussion_r1440540961
##########
src/main/java/org/apache/bcel/generic/LDC.java:
##########
@@ -109,6 +111,9 @@ public Object getValue(final ConstantPoolGen cpg) {
final int nameIndex = ((org.apache.bcel.classfile.ConstantClass)
c).getNameIndex();
c = cpg.getConstantPool().getConstant(nameIndex);
return
Type.getType(Type.internalTypeNameToSignature(((org.apache.bcel.classfile.ConstantUtf8)
c).getBytes()));
+ case org.apache.bcel.Const.CONSTANT_Dynamic:
+ // Really not sure what to return here, maybe a BootstrapMethod
instance but how do we get it?
+ return c;
Review Comment:
Any guidance or pointer would be very helpful here: my understanding is that
the _value_ should be the return of the invocation of a bootstrap method, so it
could be anything.
I'm not sure what's the best way for BCEL to convey this information because
even the type of this value does not seem to be available here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
