elharo commented on code in PR #553:
URL: https://github.com/apache/commons-io/pull/553#discussion_r1441847412
##########
src/main/java/org/apache/commons/io/FilenameUtils.java:
##########
@@ -669,7 +669,7 @@ public static String getFullPath(final String fileName) {
* ~ --> ~
* ~/ --> ~
* ~user --> ~user
- * ~user/ --> ~user
+ * ~user/ --> ~user/
Review Comment:
The existing javadoc and API is very unclear. I do not understand "Gets the
full path from a full fileName, which is the prefix + path, and also excluding
the final directory separator."
The argument is not a filename. There is no such thing as a "full path" in
normal parlance. Bug filed. https://issues.apache.org/jira/browse/IO-836
I also agree that if this method turns ~user/ into ~user/ that's a bug. It
should produce ~user.
C:\ should also (80% certainty) turn into C:, not C:\
I further expect there are additional bugs in this method involving Unix
shell conventions and platform dependencies, but I'd have to dig into the rest
of the class to understand exactly what those are.
What a tasy can of worms you've opened. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
