JuditKnoll commented on PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#issuecomment-1877654007

   Thank you very much for your PR @gtoison!
   I looked at the usages of `Const.CONSTANT_Integer`, and found two functions 
where `Const.CONSTANT_Dynamic` is not handled, but I think it should be:
   - 
[ConstantPoolX.constantToString()](https://github.com/apache/commons-bcel/blob/master/src/test/java/org/apache/bcel/data/ConstantPoolX.java#L96),
   - 
[ConstantPoolGen.addConstant()](https://github.com/apache/commons-bcel/blob/master/src/main/java/org/apache/bcel/generic/ConstantPoolGen.java#L275).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to