Marcono1234 opened a new pull request, #143: URL: https://github.com/apache/commons-exec/pull/143
The GitHub workflow file had hardcoded `runs-on: ubuntu-latest`, so even though the title of the builds said something like "build (windows-latest, 21, false)", it was actually always running using Ubuntu. I have also adjusted the unit tests to use JUnit annotations to disable the tests on certain OS'. Because there is no UNIX constant for `org.junit.jupiter.api.condition.OS`, I changed the logic from only running on UNIX to not running on Windows. As side note: Previously on Windows unit tests would fail due to tests in `Exec65Test` failing execution by throwing an `ExecuteException`, instead of just skipping execution. For `org.junit.jupiter.api.condition.OS` I used the fully qualified name to avoid confusion with the `org.apache.commons.exec.OS` class in this project. At lot of the changes are indentation changes; please edit your Git client / GitHub setting to disable whitespace diff when reviewing the changes. Feedback is appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
