psteitz commented on PR #322: URL: https://github.com/apache/commons-dbcp/pull/322#issuecomment-1899290620
Sorry for the very slow response. I think this is good to merge. I agree tests would be nice, but like the OP, I can't think of a simple way to demonstrate the impact of the pinning, which is pretty certain to happen on the (not normal) execution paths where connections get physically closed. This should have no impact on performance in earlier JDKs. I also verified that no other code relies on this object's monitor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
