garydgregory commented on PR #378: URL: https://github.com/apache/commons-compress/pull/378#issuecomment-1901074371
Hello All I am -1 until tests are provided that show the new data structure is correctly populated. A package-private getter can be added and queried by new unit tests for example. Otherwise, it's just too easy undo in the future without visibility. If this were indeed undone in the future, then forcing a maintainer to remove tests will make it obvious that this was a intended feature. Edge cases should IMO account for no duplicates, some duplicated, all duplicates use cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
