[
https://issues.apache.org/jira/browse/LOGGING-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810933#comment-17810933
]
Elliotte Rusty Harold commented on LOGGING-163:
-----------------------------------------------
Not sure why fix version is 1.3.1. Given the dates, I'd expect 1.3.0
> BufferedReader is not closed properly
> -------------------------------------
>
> Key: LOGGING-163
> URL: https://issues.apache.org/jira/browse/LOGGING-163
> Project: Commons Logging
> Issue Type: Bug
> Affects Versions: 1.1.1, 1.2
> Reporter: Kaloyan Spiridonov
> Assignee: Gary D. Gregory
> Priority: Major
> Fix For: 1.3.1
>
>
> In LogFactory class at line 552 there is BufferedReader that is not closed
> properly. For example if rd.readLine(); throw an exception then the Reader
> will remain open.
> {code}
> BufferedReader rd;
> try {
> rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
> } catch (java.io.UnsupportedEncodingException e) {
> rd = new BufferedReader(new InputStreamReader(is));
> }
> String factoryClassName = rd.readLine();
> rd.close();
> {code}
> In SimpleLog class at line 163 there is InputStream that is not closed
> properly.
> {code}
> InputStream in = getResourceAsStream("simplelog.properties");
> if(null != in) {
> try {
> simpleLogProps.load(in);
> in.close();
> } catch(java.io.IOException e) {
> // ignored
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
