garydgregory commented on code in PR #566:
URL: https://github.com/apache/commons-io/pull/566#discussion_r1467728534
##########
src/main/java/org/apache/commons/io/EndianUtils.java:
##########
@@ -182,13 +194,14 @@ public static short readSwappedShort(final InputStream
input) throws IOException
}
/**
- * Reads an unsigned integer (32-bit) value from a byte array at a given
- * offset. The value is converted to the opposed endian system while
- * reading.
+ * Reads a little endian unsigned integer (32-bit) value from a byte array
at a given
Review Comment:
Hi @elharo
This is slightly confusing to me: The method returns a `long` (64-bit) but
we are reading an 32-bit integer? Should we clarify this point? Something like
"Read a foo as a bar".
##########
src/main/java/org/apache/commons/io/EndianUtils.java:
##########
@@ -182,13 +194,14 @@ public static short readSwappedShort(final InputStream
input) throws IOException
}
/**
- * Reads an unsigned integer (32-bit) value from a byte array at a given
- * offset. The value is converted to the opposed endian system while
- * reading.
+ * Reads a little endian unsigned integer (32-bit) value from a byte array
at a given
Review Comment:
Hi @elharo
This is slightly confusing to me: The method returns a `long` (64-bit) but
we are reading an 32-bit integer? Should we clarify this point? Something like
"Reads a foo as a bar".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
