elharo commented on PR #575: URL: https://github.com/apache/commons-io/pull/575#issuecomment-1919419308
I think anything that breaks would reveal a bug in our code or, less likely, the JDK. There are no null pointer exceptions here because all the variables are primitives or previously dereferenced before the try block. The only methods that throw as a result of bad encoding are parseInt, substring, and charAt. Those are well documented and understood. If ByteBuffer throws, that's definitely a bug in our code we shouldn't ignore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
