theshoeshiner commented on PR #1167: URL: https://github.com/apache/commons-lang/pull/1167#issuecomment-1921293997
It looks like the only way to add the No-op functionality is to create an anonymous EventListenerSupport class, correct? That's a bit unintuitive but I suppose it requires fewer changes to the existing class. Given that firing quietly was the entire reason for this change maybe it's worth mentioning in the javadoc? At the end of the day this does address the issue of firing quietly so this should work for me. If I end up needing a more robust implementation then it would probably be best to leave this class as-is and create something new that doesn't involve proxies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
