StefanOltmann commented on PR #359: URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-1925758043
> I don't see any new tests here. I did not commit it. I added the file above locally to the test folders hoping that one of the rewrite tests will pick it up and fail. It gets actually processed, but the existing tests do not fail, because they don’t detect the issue. There is apparently a lack of coverage here. The test that might pick it up is still disabled, because the author never finished it. See this comment: https://github.com/apache/commons-imaging/pull/275#pullrequestreview-1305362377 The offsets are actually expected to change and must be ignored. The wrong orientation value is most likely a problem that came from changing the byte order. I guess I need to fix that test first to have a proper unit tests, before I can add an image that breaks them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
