garydgregory commented on code in PR #240:
URL: https://github.com/apache/commons-codec/pull/240#discussion_r1478262382
##########
src/test/java/org/apache/commons/codec/binary/Base64Test.java:
##########
@@ -1309,6 +1309,11 @@ public void testUrlSafe() {
}
+ public void testCodec263(){
+ Base64.decodeBase64("publishMessage");
Review Comment:
I would make it more obvious IMO to refactor the magic strings into a local
variable (or a constant).
##########
src/test/java/org/apache/commons/codec/binary/Base64Test.java:
##########
@@ -1309,6 +1309,11 @@ public void testUrlSafe() {
}
+ public void testCodec263(){
+ Base64.decodeBase64("publishMessage");
Review Comment:
@elharo
It would make it more obvious IMO to refactor the magic strings into a local
variable (or a constant).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
