elharo commented on PR #582: URL: https://github.com/apache/commons-io/pull/582#issuecomment-1934672359
This PR seems unlikely to require source changes by users. These methods can already throw IOExceptions and those need to be handled. The only potential problem, and it's not a likely one, is if someone has a separate IllegalArgumentException catch block with special logic to handle read only files. In that case they'd need to move that logic into a block that catches IOException. However, I think more users are likely to be helped by combining IOException into a single exception type. As to simply removing the writeable check completely, that's a definite maybe. It would simplify the code, and simplify the happy path where there's no problem with read-only files. Public API remains the same. It's a very good point that this risks being out of sync with the fiel system by the time we write. Should I go ahead and remove the requireCanWrite method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
