garydgregory commented on PR #480: URL: https://github.com/apache/commons-compress/pull/480#issuecomment-1937102315
> @garydgregory very good catch! fixed now normally. On the builder point I had the same thought and I think it is maybe worth to not expose all constructors (package scope?) and just use a single one for next release, the builder will make the api more verbose with a very low gain since most constructors are just about calling setters - and extra fields are exactly there for example. Hi @rmannibucau - I think that for this PR, the constructor changes should be as minimal and visible as you can make them, so yes, package-private or private is the way to go. - Once this PR is done, I can experiment with a Builder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
