[
https://issues.apache.org/jira/browse/LANG-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816436#comment-17816436
]
Elliotte Rusty Harold commented on LANG-1653:
---------------------------------------------
Good catch. I'm not sure what to do here. These are deprecated now and perhaps
since the types are private so they couldn't be used, we can gte away with a
purely technical semver violation and just remove them? I'm not sure.
> API visibility issues: Internal types are exposed in public API
> ---------------------------------------------------------------
>
> Key: LANG-1653
> URL: https://issues.apache.org/jira/browse/LANG-1653
> Project: Commons Lang
> Issue Type: Bug
> Affects Versions: 3.12.0
> Reporter: Marcono1234
> Priority: Minor
>
> There are a few cases where public classes expose internal {{private}} types.
> These internal types prevent usage of the methods or fields exposing them.
> Affected:
> - {{org.apache.commons.lang3.ThreadUtils}}: Exposes private type
> {{AlwaysTruePredicate}} through field
> [{{ALWAYS_TRUE_PREDICATE}}|https://github.com/apache/commons-lang/blob/d1e9e598c9bcbf91afa174fa9b6c2ef30bbc8157/src/main/java/org/apache/commons/lang3/ThreadUtils.java#L148]
> The field should probably instead have the type {{ThreadPredicate}}.
> - {{org.apache.commons.lang3.time.FastDatePrinter}}: The following protected
> methods expose private types:
> --
> [{{selectNumberRule}}|https://github.com/apache/commons-lang/blob/d1e9e598c9bcbf91afa174fa9b6c2ef30bbc8157/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java#L385]:
> Exposes private {{NumberRule}}
> --
> [{{parsePattern}}|https://github.com/apache/commons-lang/blob/d1e9e598c9bcbf91afa174fa9b6c2ef30bbc8157/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java#L185]:
> Exposes private {{Rule}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
