thc202 commented on code in PR #217:
URL: https://github.com/apache/commons-net/pull/217#discussion_r1487544841
##########
src/main/java/org/apache/commons/net/ftp/FTPHTTPClient.java:
##########
@@ -194,8 +194,8 @@ private BufferedReader tunnelHandshake(final String host,
final int port, final
final String auth = proxyUserName + ":" + proxyPassword;
final String header = "Proxy-Authorization: Basic " +
Base64.getEncoder().encodeToString(auth.getBytes(charset));
output.write(header.getBytes(charset));
+ output.write(CRLF);
}
- output.write(CRLF);
Review Comment:
This one should be kept,
https://datatracker.ietf.org/doc/html/rfc7230#autoid-15
> an empty line indicating the end of the header section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
