garydgregory commented on code in PR #233:
URL: https://github.com/apache/commons-cli/pull/233#discussion_r1489645584
##########
src/main/java/org/apache/commons/cli/DefaultParser.java:
##########
@@ -228,6 +228,9 @@ private DefaultParser(final boolean allowPartialMatching,
*/
private void checkRequiredArgs() throws ParseException {
if (currentOption != null && currentOption.requiresArg()) {
+ if (isJavaProperty(currentOption.getKey()) &&
currentOption.getValues().length == 1) {
Review Comment:
Hi @Claudenw
I think you are missing a test case to account for `Option#getValues()`
returning `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
