pingpingy1 commented on code in PR #236:
URL: https://github.com/apache/commons-math/pull/236#discussion_r1498871688
##########
commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/ranking/NaturalRanking.java:
##########
@@ -158,8 +158,8 @@ public NaturalRanking(NaNStrategy nanStrategy,
private NaturalRanking(NaNStrategy nanStrategy,
TiesStrategy tiesStrategy,
UniformRandomProvider random) {
- this.nanStrategy = nanStrategy;
- this.tiesStrategy = tiesStrategy;
+ this.nanStrategy = nanStrategy != null ? nanStrategy :
DEFAULT_NAN_STRATEGY;
Review Comment:
Sounds good. Let me modify the test case accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
