kinow commented on PR #367: URL: https://github.com/apache/commons-imaging/pull/367#issuecomment-1967611057
>There is really a serious bug present and my PR fixes it. I swear! And from a quick read at the code I think you might be correct :slightly_smiling_face: >However, I can remove it from the PR if you want. We can wait a bit longer for other to review the legal issue. >Maybe if you and/or @kinow have seen and verified that both the bugfix and test are correct using the image locally/temporary, this is enough proof. > >The only thing that will be lost without the image is a regression protection. Yup, but the issue is that when a regression like that happens, it's quite annoying to have to either fix it or, in some cases, depending on how much the API changed, spend a long time debugging and then have to maybe modify the API, breaking binary compatibility (talking about worst cases). Which is why we try to enforce the policy to always include tests with the changes. We know from experience that hurrying to get things merged and released can result in issues (while the counterargument that taking too long to do so is equally bad, so we must aim at achieving a compromise). @StefanOltmann, from what I understood, you wrote the fix and a test. You used an image with a license that could be blocked by ASF's legal. But IMHO, you went the extra mile already by writing the test and trying to sort out the issue. You don't have to do everything yourself :slightly_smiling_face: You can leave the PR as-is, and one of us can take a look to see if we can find other images, or even craft one using some editor like GIMP, or searching in other archives, etc. I did that in some past PR's, so that wouldn't be a problem for me [^1]. WDYT? Bruno [^1]: BTW, I thought about writing a utility test code to read a configuration spec for an image, and produce it with Commons Imaging (or another lib in Java/Python/C/Rust/etc.). For example: `create-image --format=png --size=10x10 --alpha=yes --chunk=$file_with_extra_chunks`, where the idea would be to produce scaffold images, and then just plug segments/chunks/xmp/exif/any other data into the image from a file or from command line... if you know of, or create such a library, this could be interesting to use in our tests :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
