garydgregory commented on code in PR #312:
URL: https://github.com/apache/commons-dbcp/pull/312#discussion_r1507877548
##########
src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java:
##########
@@ -422,7 +422,7 @@ public Object getObjectInstance(final Object obj, final
Name name, final Context
private void validatePropertyNames(final Reference ref, final Name name,
final List<String> warnMessages,
final List<String> infoMessages) {
final String nameString = name != null ? "Name = " + name.toString() +
" " : "";
- if (NUPROP_WARNTEXT != null && !NUPROP_WARNTEXT.isEmpty()) {
+ if (!NUPROP_WARNTEXT.isEmpty()) {
Review Comment:
commit e627d55fe8a33b3ca482aac1da1b5555761c6146
##########
src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java:
##########
@@ -422,7 +422,7 @@ public Object getObjectInstance(final Object obj, final
Name name, final Context
private void validatePropertyNames(final Reference ref, final Name name,
final List<String> warnMessages,
final List<String> infoMessages) {
final String nameString = name != null ? "Name = " + name.toString() +
" " : "";
- if (NUPROP_WARNTEXT != null && !NUPROP_WARNTEXT.isEmpty()) {
+ if (!NUPROP_WARNTEXT.isEmpty()) {
Review Comment:
commit e627d55fe8a33b3ca482aac1da1b5555761c6146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
