[ 
https://issues.apache.org/jira/browse/BEANUTILS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822530#comment-17822530
 ] 

Samael Bate commented on BEANUTILS-439:
---------------------------------------

the logger in MethodUtils is currently static:
{code:java}
private static final Log LOG = LogFactory.getLog(MethodUtils.class); {code}
[https://github.com/apache/commons-beanutils/blob/30f6e56473e03604b172a4b38ecd80fe48687532/src/main/java/org/apache/commons/beanutils2/MethodUtils.java#L116]

There is some trace level logging and a single debug log.

 

Should this issue be closed?

> Save Logger in static field in MethodUtils instead of requesting it on every 
> method invocation
> ----------------------------------------------------------------------------------------------
>
>                 Key: BEANUTILS-439
>                 URL: https://issues.apache.org/jira/browse/BEANUTILS-439
>             Project: Commons BeanUtils
>          Issue Type: Improvement
>          Components: Bean / Property Utils
>    Affects Versions: 1.8.3
>            Reporter: Benedikt Ritter
>            Assignee: Benedikt Ritter
>            Priority: Major
>              Labels: logging, performance
>             Fix For: 2.0.0
>
>
> It was proposed on the ML to create a static field reference to the Logger in 
> MethodUtils, because requesting it on every method invocation leads to bad 
> performance (see http://markmail.org/message/ysurofedfoikdguu).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to