speters33w commented on PR #528: URL: https://github.com/apache/commons-text/pull/528#issuecomment-2048290598
You make some good points, to have at most one or two methods with a parameter for delimeter. I will revisit this. One concern is the existing char[] for delimeter in the existing toCamelCase method is to define delimiters to exclude, where my methods would use a char or string for character to use between words. I will definately revisit this and do a new push to my fork. Thank you. On Wed, Apr 10, 2024, 09:35 Matt Benson ***@***.***> wrote: > ***@***.**** commented on this pull request. > > I am missing the rationale for embedding the stripping of accent chars > into the notion of converting to title case, or any other conversion. You > are already delegating to a utility method for this purpose; couldn't the > API consumer do that it needed? I would also prefer a design more like one > common implementation with parameters for delimiter, case(, etc.?) rather > than e.g. kebab = snake + s/_/-/ . > > Additionally, I have a preference for "Pascal" to "upper camel" for the > seeming uniformity of having a single word to describe the desired > structure, notwithstanding combinations like "screaming snake." > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-text/pull/528#pullrequestreview-1991714141>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AF72ZOZZWHFOZSZAMUOFPZDY4U52LAVCNFSM6AAAAABF7LF7D6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOJRG4YTIMJUGE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
