pedro-w commented on PR #205: URL: https://github.com/apache/commons-rdf/pull/205#issuecomment-2051671643
Just to keep everything in one place I made some comments [here](https://lists.apache.org/thread/m020v4wr8fcwjvr417gb3fykdzlt772b) which I have reproduced below 1. Better IMO to add a default method to the interface rather than adding 11 implementations which are almost identical 2. No need to restrict it to a List when any iterable would do 3. There is a bulk 'add' method in RepositoryConnection (https://rdf4j.org/javadoc/latest/org/eclipse/rdf4j/repository/RepositoryConnection.html#add(java.lang.Iterable,org.eclipse.rdf4j.model.Resource...) - might be better to use it 4. Why was RDF4JServiceLoaderTest.java deleted? 5. Method name 'addAll' is more consistent with Java collections but it seems RDF4J uses 'add' overloaded for single or multiple additions - don't know if Commons has any preference on that. and also in [that thread](https://lists.apache.org/thread/rs4d5tzpf3sx0fxllhx3yy8gbczvksnx) I added a patch which is related to 1 & 2 on the list above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
