speters33w commented on PR #450: URL: https://github.com/apache/commons-text/pull/450#issuecomment-2059348369
Yeah, I don't know what I did, but it works, now, including my new test. ``` Process finished with exit code 0 ``` You might need to rebase your project and do a push, I don't know if it has to do with 1.12RC, or something, but I tried re-cloning from this PR, and none of your work was in it. Then I tried cloning directly from your repository, same thing, then I tried downloading the zip file from your repository and all your work was gone. I had to manually copy cases directory, the matcher files you edited, all the tokenizer stuff, etc. from the one I cloned a couple days ago into the new clone, and git thinks they are new and changed files. The release notes in what I downloaded say 1.11.0 Weird. This PR and my [PR 528](https://github.com/apache/commons-text/pull/528) are not incompatible with each other. They serve different purposes. Mine is designed to get everything into lower ASCII and spit out the string, while yours is designed to keep the Unicode characters intact as tokens for future manipulation. I don't think mine can handle UTF32 characters, so ๐กโ๐_๐๐ข๐๐๐_๐๐๐๐ค๐_๐๐๐ฅ would fail as an input on [528](https://github.com/apache/commons-text/pull/528). I'll have to try it. I haven't, yet. I frittered away my morning playing with this pull (most of it trying to re-clone) so I will have to revisit it because I have a bunch of other stuff to do today. I'll probably re-visit Sunday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
