garydgregory commented on code in PR #1201:
URL: https://github.com/apache/commons-lang/pull/1201#discussion_r1568055953
##########
src/main/java/org/apache/commons/lang3/StringUtils.java:
##########
@@ -8135,12 +8135,11 @@ public static String strip(String str, final String
stripChars) {
*/
// See also Lucene's ASCIIFoldingFilter (Lucene 2.9) that replaces
accented characters by their unaccented equivalent (and uncommitted bug fix:
https://issues.apache.org/jira/browse/LUCENE-1343?focusedCommentId=12858907&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12858907).
public static String stripAccents(final String input) {
- if (input == null) {
- return null;
+ if (StringUtils.isEmpty(input)) {
Review Comment:
You don't need a FQCN here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
