[
https://issues.apache.org/jira/browse/POOL-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz resolved POOL-158.
------------------------------
Resolution: Fixed
After looking carefully at the code, I concluded that making the field volatile
is a better solution. For the evict() read, there is no other reason to
acquire a pool lock in the initial check.
> References to GenericKeyedObjectPool._minIdle are not always synchronized
> -------------------------------------------------------------------------
>
> Key: POOL-158
> URL: https://issues.apache.org/jira/browse/POOL-158
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.2, 1.4, 1.5, 1.5.1, 1.5.2, 1.5.3, 1.5.4
> Reporter: Sebb
> Fix For: 1.5.5
>
>
> References to GenericKeyedObjectPool._minIdle are not always synchronized:
> The ensureMinIdle() and evict() methods both access the field outside the
> synch. block.
> This is particularly bad as they are called from the timer thread.
> The references could use getMinIdle(), which is synch., or it would probably
> be cheaper to move the references into the synch. blocks.
> Better yet, can the field be made final? setMinIdle() is currently only
> called from Test cases and setConfig() which is not referenced AFAICT.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
