garydgregory commented on PR #239: URL: https://github.com/apache/commons-email/pull/239#issuecomment-2067687131
Hello @seanfabs I can't reproduce these results unless a benchmark run executes tests with old and new code. You can usually do this by copying old code into a benchmark test method so that you have two methods: One tests the new patched main code and the old runs the old code now living in the benchmark; in this case, it's not much code since these are REs. Please rebase on git master to pick up the new Maven I added to facilitate running benchmarks from the command line like `mvn -P benchmark -Dbenchmark=ImageHtmlEmailBenchmark -pl commons-email2-jakarta`. TY! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
