rikkarth commented on code in PR #412:
URL:
https://github.com/apache/commons-configuration/pull/412#discussion_r1586368443
##########
src/main/java/org/apache/commons/configuration2/DatabaseConfiguration.java:
##########
@@ -478,6 +478,21 @@ protected Boolean performOperation() throws SQLException {
return result != null && result.booleanValue();
}
+ @Override
+ protected boolean containsValueInternal(final String value) {
+ final AbstractJdbcOperation<Boolean> op = new
AbstractJdbcOperation<Boolean>(ConfigurationErrorEvent.READ,
ConfigurationErrorEvent.READ, value, null) {
+ @Override
+ protected Boolean performOperation() throws SQLException {
+ try (ResultSet rs =
openResultSet(String.format(SQL_GET_PROPERTY, table, valueColumn), true,
value)) {
+ return rs.next();
Review Comment:
Turned it off but defined a test to check for return.
It asserts correctly.
Thank you.
```java
@Test
public void testContainsValue() throws ConfigurationException {
final DatabaseConfiguration config = helper.setUpConfig();
config.addPropertyDirect("test", "test1");
assertTrue(config.containsValue("test1"));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
