garydgregory commented on PR #217:
URL: 
https://github.com/apache/commons-validator/pull/217#issuecomment-2096227738

   > The theoretical MIN valid EC-Number is 000-001-6;
   
   OK, then please add a test for that, something like `testMinimum()`, and the 
whatever the max value is (if there is one, if not something that looks very 
large). 
   
   My concern is that if the RE says "this segment can be 1, 2, or 3 digits", 
then there should be assertions for that.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to