[
https://issues.apache.org/jira/browse/NET-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844276#comment-17844276
]
Jacob Vandborg commented on NET-710:
------------------------------------
Hi [~sebb],
Thank you for looking into this issue.
I've also not been able to replicate the mentioned error using sample code
provided, but I've successfully been able to replicate the problem using this
example:
{code:java}
public static void main(String[] args) throws ParseException {
String ts = "Mar 31 02:37";
Calendar serverTime = Calendar.getInstance(TimeZone.getTimeZone("CET"),
Locale.forLanguageTag("da"));
Calendar c = new FTPTimestampParserImpl().parseTimestamp(ts, serverTime);
}
{code}
When debugging through FTPTimestampParserImpl it seems the problems start
around line 159
{noformat}
parsed = hackFormatter.parse(timeStampStrPlusYear, pp);
{noformat}
where the method call returns null into 'parsed'-variable
I've tested above in commons-net 3.10 on the following java version:
{noformat}
openjdk 17.0.11 2024-04-16
OpenJDK Runtime Environment Temurin-17.0.11+9 (build 17.0.11+9)
OpenJDK 64-Bit Server VM Temurin-17.0.11+9 (build 17.0.11+9, mixed mode)
{noformat}
The SFTP server I've connected to is running UTC and therefore does not
observer daylight saving time.
Best regards,
Jacob
> Timestamp parsing fails around the change to daylight savings
> -------------------------------------------------------------
>
> Key: NET-710
> URL: https://issues.apache.org/jira/browse/NET-710
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
> Affects Versions: 3.3, 3.8.0
> Reporter: Mike Baranczak
> Priority: Major
>
> {{String ts = "Mar 13 02:33";}}
> {{Calendar serverTime = Calendar.getInstance(TimeZone.getTimeZone("EDT"),
> Locale.US);}}
> {{serverTime.set(2022, 2, 16, 14, 0);}}
> {{Calendar c = new FTPTimestampParserImpl().parseTimestamp(ts, serverTime);}}
>
> {{Result:}}
>
> {{java.text.ParseException: Timestamp 'Mar 13 02:33' could not be parsed
> using a server time of Wed Mar 16 10:00:54 EDT 2022}}
> {{ at
> org.apache.commons.net.ftp.parser.FTPTimestampParserImpl.parseTimestamp
> (FTPTimestampParserImpl.java:246)}}
>
> I can't tell what's going on, but this seems to have something to do with the
> transition to Daylight Savings Time, which happened on Sunday, March 13. I
> ran into this bug when trying to get a list of recent files from an FTP
> server. (UnixFTPEntryParser ignores the exception silently, which isn't a
> great idea, either.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
