[ 
https://issues.apache.org/jira/browse/DAEMON-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845281#comment-17845281
 ] 

Michael Osipov commented on DAEMON-463:
---------------------------------------

This does work:
{noformat}
$ git diff
diff --git a/src/native/unix/native/jsvc-unix.c 
b/src/native/unix/native/jsvc-unix.c
index e331a0f..187e404 100644
--- a/src/native/unix/native/jsvc-unix.c
+++ b/src/native/unix/native/jsvc-unix.c
@@ -1308,7 +1308,7 @@ static int run_controller(arg_data *args, home_data 
*data, uid_t uid, gid_t gid)
      * These will be replaced in the child process.
      */
     memset(&act, '\0', sizeof(act));
-    act.sa_handler = controller;
+    act.sa_sigaction = controller;
     sigemptyset(&act.sa_mask);
     act.sa_flags = SA_RESTART | SA_NOCLDSTOP | SA_SIGINFO;
 {noformat}
but I have no clue how to test/comply with: If the SA_SIGINFO flag is set in 
the sa_flags field, and the implementation supports the Realtime Signals 
Extension option or the XSI Extension option, the sa_sigaction field specifies 
a signal-catching function. [Option End]
from https://pubs.opengroup.org/onlinepubs/009696699/functions/sigaction.html

> Daemon fails to build on macOS with XCode 15.3
> ----------------------------------------------
>
>                 Key: DAEMON-463
>                 URL: https://issues.apache.org/jira/browse/DAEMON-463
>             Project: Commons Daemon
>          Issue Type: Bug
>          Components: Jsvc
>    Affects Versions: 1.3.4
>         Environment:  
> Clang: 15.0.0 build 1500
> macOS: 14.4.1-arm64 
> CLT: 15.3.0.0.1.1708646388 
> Xcode: 15.3 
> Rosetta 2: false
>            Reporter: Sean Molenaar
>            Priority: Major
>
> When building jsvc on macOS with XCode 15.3 (for Homebrew), the build fails 
> with the following error:
>  
> {code:java}
>  jsvc-unix.c:1311:20: error: incompatible function pointer types assigning to 
> 'void (*)(int)' from 'void (int, siginfo_t *, void *)' (aka 'void (int, 
> struct __siginfo *, void *)') [-Wincompatible-function-pointer-types]    90  
> act.sa_handler = controller;    91  ^ ~~~~~~~~~~ {code}
>  
> For more details see: 
> https://github.com/Homebrew/homebrew-core/actions/runs/8967899390/job/24626304630
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to