garydgregory commented on code in PR #314:
URL:
https://github.com/apache/commons-fileupload/pull/314#discussion_r1606065057
##########
src/main/java/org/apache/commons/fileupload/FileUploadBase.java:
##########
@@ -1069,13 +1080,23 @@ private boolean findNextItem() throws IOException {
eof = true;
return false;
}
+
Review Comment:
No extra whitespace needed.
##########
src/main/java/org/apache/commons/fileupload/FileUploadBase.java:
##########
@@ -138,6 +138,11 @@ public static boolean isMultipartContent(final
HttpServletRequest req) {
*/
public static final String MULTIPART_MIXED = "multipart/mixed";
+ /**
+ * HTTP content type header for multiple related data.
+ */
+ public static final String MULTIPART_RELATED = "multipart/related";
Review Comment:
New public and protected items need a Javadoc 'since tag.
##########
src/test/java/org/apache/commons/fileupload/FileUploadTest.java:
##########
@@ -396,4 +397,53 @@ private void assertHeaders(final String[] pHeaderNames,
final String[] pHeaderVa
}
}
}
+
+ /**
+ * Test for multipart/related without any content-disposition Header.
+ * <p/>
Review Comment:
No empty tag, instead enclose the paragraph.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
